oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

DecoderAPI: pass rvalue reference to decoder_tag()

Browse Source 
Avoid duplicating the tag.
This commit is contained in:
Max Kellermann
2013-07-31 00:34:22 +02:00
parent 06f898cc12
commit cbd38327e7
9 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/DecoderAPI.cxx
View File

@@ -471,19 +471,18 @@ decoder_data(struct decoder *decoder,
enum decoder_command
decoder_tag(G_GNUC_UNUSED struct decoder *decoder, struct input_stream *is,
const Tag *tag)
Tag &&tag)
{
G_GNUC_UNUSED const struct decoder_control *dc = decoder->dc;
enum decoder_command cmd;
assert(dc->state == DECODE_STATE_DECODE);
assert(dc->pipe != NULL);
assert(tag != NULL);
/* save the tag */
delete decoder->decoder_tag;
decoder->decoder_tag = new Tag(*tag);
decoder->decoder_tag = new Tag(tag);
/* check for a new stream tag */
@@ -509,7 +508,7 @@ decoder_tag(G_GNUC_UNUSED struct decoder *decoder, struct input_stream *is,
delete merged;
} else
/* send only the decoder tag */
cmd = do_send_tag(decoder, *tag);
cmd = do_send_tag(decoder, *decoder->decoder_tag);
return cmd;
}