oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

filter/Filter: Flush() returns empty span, not nullptr

This commit is contained in:
Max Kellermann 2024-11-05 13:16:28 +01:00
parent d6195025fb
commit bcab29d53a
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/filter/Filter.hxx
View File

@ -49,7 +49,7 @@ public:
/** /**
* Flush pending data and return it. This should be called * Flush pending data and return it. This should be called
* repeatedly until it returns nullptr. * repeatedly until it returns an empty span.
* *
* After calling this method, this object cannot be used again * After calling this method, this object cannot be used again
* (not even Reset() is allowed). * (not even Reset() is allowed).

2
src/output/Thread.cxx
View File

@ -389,7 +389,7 @@ AudioOutputControl::InternalDrain() noexcept
while (true) { while (true) {
auto buffer = source.Flush(); auto buffer = source.Flush();
if (buffer.data() == nullptr) if (buffer.empty())
break; break;
PlayFull(*output, buffer); PlayFull(*output, buffer);

2
test/run_filter.cxx
View File

@ -128,7 +128,7 @@ try {
while (true) { while (true) {
auto dest = filter->Flush(); auto dest = filter->Flush();
if (dest.data() == nullptr) if (dest.empty())
break; break;
output_fd.FullWrite(dest); output_fd.FullWrite(dest);
} }