oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

command: add COMMAND_RETURN_IDLE

Browse Source 
Eliminate the hack in handle_idle().
This commit is contained in:
Max Kellermann 2012-09-25 12:04:20 +02:00
parent e47240931a
commit b62a8e3e3e
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/OtherCommands.cxx
View File

@ -310,6 +310,5 @@ handle_idle(struct client *client,
/* enable "idle" mode on this client */ /* enable "idle" mode on this client */
client_idle_wait(client, flags); client_idle_wait(client, flags);
/* return value is "1" so the caller won't print "OK" */ return COMMAND_RETURN_IDLE;
return (enum command_return)1;
} }

1
src/client_event.c
View File

@ -77,6 +77,7 @@ client_in_event(G_GNUC_UNUSED GIOChannel *source, GIOCondition condition,
ret = client_read(client); ret = client_read(client);
switch (ret) { switch (ret) {
case COMMAND_RETURN_OK: case COMMAND_RETURN_OK:
case COMMAND_RETURN_IDLE:
case COMMAND_RETURN_ERROR: case COMMAND_RETURN_ERROR:
break; break;

6
src/command.h
View File

@ -31,6 +31,12 @@ enum command_return {
*/ */
COMMAND_RETURN_OK, COMMAND_RETURN_OK,
/**
* The connection is now in "idle" mode, and no response shall
* be generated.
*/
COMMAND_RETURN_IDLE,
/** /**
* There was an error. The "ACK" response was sent to the * There was an error. The "ACK" response was sent to the
* client. * client.