oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

De-inline non-trivial, non-performance-critical functions

Browse Source 
Functions that should stay inlined should have an explanation
attached to them.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4355 09075e82-0dd4-0310-85a5-a0d7c8717e4f
This commit is contained in:
Eric Wong
2006-07-15 13:42:57 +00:00
parent 563e4c95fd
commit b4df8b8f88
7 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/inputPlugins/_flac_common.h
View File

@@ -60,6 +60,7 @@ void flac_error_common_cb( const char * plugin,
MpdTag * copyVorbisCommentBlockToMpdTag(const FLAC__StreamMetadata * block,
MpdTag * tag);
/* keep this inlined, this is just macro but prettier :) */
static inline int flacSendChunk(FlacData * data)
{
if (sendDataToOutputBuffer(data->cb, NULL, data->dc, 1, data->chunk,

3
src/inputPlugins/mpc_plugin.c
View File

@@ -82,7 +82,8 @@ static mpc_int32_t mpc_getsize_cb(void * vdata) {
return data->inStream->size;
}
inline mpd_sint16 convertSample(MPC_SAMPLE_FORMAT sample) {
/* this _looks_ performance-critical, don't de-inline -- eric */
static inline mpd_sint16 convertSample(MPC_SAMPLE_FORMAT sample) {
/* only doing 16-bit audio for now */
mpd_sint32 val;

2
src/inputPlugins/oggvorbis_plugin.c
View File

@@ -103,7 +103,7 @@ long ogg_tell_cb(void * vdata) {
return (long)(data->inStream->offset);
}
static inline char * ogg_parseComment(char * comment, char * needle) {
static char * ogg_parseComment(char * comment, char * needle) {
int len = strlen(needle);
if(strncasecmp(comment, needle, len) == 0 && *(comment+len) == '=') {