oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

[clang-tidy] remove needless std::move 

Found with performance-move-const-arg

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-02-05 16:47:14 -08:00 committed by Max Kellermann
parent 85e33f7d60
commit ac50bb5d2b
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/client/ThreadBackgroundCommand.cxx
View File

@ -54,7 +54,7 @@ ThreadBackgroundCommand::DeferredFinish() noexcept
Response response(client, 0);
if (error) {
PrintError(response, std::move(error));
PrintError(response, error);
} else {
SendResponse(response);
command_success(client);

2
src/config/File.cxx
View File

@ -72,7 +72,7 @@ config_read_name_value(ConfigBlock &block, char *input, unsigned line)
throw FormatRuntimeError("\"%s\" is duplicate, first defined on line %i",
name, bp->line);
block.AddBlockParam(name, std::move(value), line);
block.AddBlockParam(name, value, line);
}
static ConfigBlock

2
src/db/plugins/ProxyDatabasePlugin.cxx
View File

@ -698,7 +698,7 @@ Visit(struct mpd_connection *connection,
if (recursive)
Visit(connection, path, recursive, filter,
visit_directory, std::move(visit_song), std::move(visit_playlist));
visit_directory, visit_song, visit_playlist);
}
gcc_pure

8
src/db/plugins/upnp/UpnpDatabasePlugin.cxx
View File

@ -368,7 +368,7 @@ UpnpDatabase::SearchSongs(const ContentDirectoryService &server,
// which we later have to detect.
const std::string path = songPath(server.getFriendlyName(),
dirent.id);
visitSong(std::move(dirent), path.c_str(),
visitSong(dirent, path.c_str(),
selection, visit_song);
}
}
@ -447,7 +447,7 @@ VisitItem(const UPnPDirObject &object, const char *uri,
switch (object.item_class) {
case UPnPDirObject::ItemClass::MUSIC:
visitSong(object, uri, selection, std::move(visit_song));
visitSong(object, uri, selection, visit_song);
break;
case UPnPDirObject::ItemClass::PLAYLIST:
@ -487,7 +487,7 @@ VisitObject(const UPnPDirObject &object, const char *uri,
case UPnPDirObject::Type::ITEM:
VisitItem(object, uri, selection,
std::move(visit_song), std::move(visit_playlist));
visit_song, visit_playlist);
break;
}
}
@ -531,7 +531,7 @@ UpnpDatabase::VisitServer(const ContentDirectoryService &server,
std::string path = songPath(server.getFriendlyName(),
dirent.id);
visitSong(std::move(dirent), path.c_str(),
visitSong(dirent, path.c_str(),
selection, visit_song);
}