oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

command/queue: use StringIsEqual() instead of memcmp()

Browse Source 
memcmp() can overflow the buffer.
This commit is contained in:
Max Kellermann 2015-11-13 21:02:33 +01:00
parent 004da5d385
commit a6bb3cf60a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/command/QueueCommands.cxx
View File

@ -34,6 +34,7 @@
#include "Partition.hxx" #include "Partition.hxx"
#include "BulkEdit.hxx" #include "BulkEdit.hxx"
#include "util/ConstBuffer.hxx" #include "util/ConstBuffer.hxx"
#include "util/StringAPI.hxx"
#include "util/UriUtil.hxx" #include "util/UriUtil.hxx"
#include "util/NumberParser.hxx" #include "util/NumberParser.hxx"
#include "util/Error.hxx" #include "util/Error.hxx"
@ -85,7 +86,7 @@ CommandResult
handle_add(Client &client, Request args, Response &r) handle_add(Client &client, Request args, Response &r)
{ {
const char *uri = args.front(); const char *uri = args.front();
if (memcmp(uri, "/", 2) == 0) if (StringIsEqual(uri, "/"))
/* this URI is malformed, but some clients are buggy /* this URI is malformed, but some clients are buggy
and use "add /" to add the whole database, which and use "add /" to add the whole database, which
was never intended to work, but once did; in order was never intended to work, but once did; in order