oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

lib/nfs/Connection: fix memory leak (and assertion failure)

Browse Source 
nfs_destroy_context() will invoke all pending callbacks with
err==-EINTR.  In CancellableCallback::Callback(), this will invoke
NfsConnection::DeferClose(), which however is only designed to be
called from nfs_service().  In non-debug mode, this will leak memory
because nfs_close_async() is never called.

Workaround: before nfs_destroy_context(), invoke nfs_close_async() on
all pending file handles.
This commit is contained in:
Max Kellermann
2014-12-14 15:56:53 +01:00
parent 80f2ba7fca
commit a543627abd
4 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@@ -1,6 +1,7 @@
ver 0.19.7 (not yet released)
* input
- nfs: fix crash while canceling a failing file open operation
- nfs: fix memory leak on connection failure
* playlist
- don't skip non-existent songs in "listplaylist"
* fix memory allocator bug on Windows