oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

[clang-tidy] use forward instead of move 

Found with bugprone-move-forwarding-reference

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-02-02 16:06:22 -08:00
parent 140d8547c7
commit a4eed3e330
No known key found for this signature in database
GPG Key ID: 36D31CFA845F0E3B
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/config/Data.cxx
View File

@ -50,7 +50,7 @@ template<typename T>
static auto
Append(std::forward_list<T> &list, T &&src)
{
return list.emplace_after(FindLast(list), std::move(src));
return list.emplace_after(FindLast(list), std::forward<T>(src));
}
void

2
src/lib/dbus/UDisks2.cxx
View File

@ -167,7 +167,7 @@ ParseObjects(ODBus::ReadMessageIter &&i,
ForEachInterface(std::move(i), [&callback](const char *path, auto &&j){
Object o(path);
ParseObject(o, std::move(j));
ParseObject(o, std::forward<decltype(j)>(j));
if (o.IsValid())
callback(std::move(o));
});

2
src/neighbor/plugins/UdisksNeighborPlugin.cxx
View File

@ -231,7 +231,7 @@ UdisksNeighborExplorer::HandleMessage(DBusConnection *, DBusMessage *message) no
dbus_message_has_signature(message, InterfacesAddedType::value)) {
RecurseInterfaceDictEntry(ReadMessageIter(*message), [this](const char *path, auto &&i){
UDisks2::Object o(path);
UDisks2::ParseObject(o, std::move(i));
UDisks2::ParseObject(o, std::forward<decltype(i)>(i));
if (o.IsValid())
this->Insert(std::move(o));
});