oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

command: "update" checks if the path is malformed 

This is a very basic check, which only ensures that the path does not
begin with a slash, doesn't have double slashes and the special names
"." and ".." are forbidden.
This commit is contained in:
Max Kellermann 2010-02-27 19:01:17 +01:00
parent 43cf4e97b9
commit a3645984cd
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -10,6 +10,7 @@ ver 0.16 (20??/??/??)
- "load" supports remote playlists (extm3u, pls, asx, xspf, lastfm://) - "load" supports remote playlists (extm3u, pls, asx, xspf, lastfm://)
- allow changing replay gain mode on-the-fly - allow changing replay gain mode on-the-fly
- omitting the range end is possible - omitting the range end is possible
- "update" checks if the path is malformed
* archive: * archive:
- iso: renamed plugin to "iso9660" - iso: renamed plugin to "iso9660"
- zip: renamed plugin to "zzip" - zip: renamed plugin to "zzip"

18
src/command.c
View File

@ -1055,9 +1055,16 @@ handle_update(struct client *client, G_GNUC_UNUSED int argc, char *argv[])
unsigned ret; unsigned ret;
assert(argc <= 2); assert(argc <= 2);
if (argc == 2) if (argc == 2) {
path = argv[1]; path = argv[1];
if (!uri_safe_local(path)) {
command_error(client, ACK_ERROR_ARG,
"Malformed path");
return COMMAND_RETURN_ERROR;
}
}
ret = update_enqueue(path, false); ret = update_enqueue(path, false);
if (ret > 0) { if (ret > 0) {
client_printf(client, "updating_db: %i\n", ret); client_printf(client, "updating_db: %i\n", ret);
@ -1076,9 +1083,16 @@ handle_rescan(struct client *client, G_GNUC_UNUSED int argc, char *argv[])
unsigned ret; unsigned ret;
assert(argc <= 2); assert(argc <= 2);
if (argc == 2) if (argc == 2) {
path = argv[1]; path = argv[1];
if (!uri_safe_local(path)) {
command_error(client, ACK_ERROR_ARG,
"Malformed path");
return COMMAND_RETURN_ERROR;
}
}
ret = update_enqueue(path, true); ret = update_enqueue(path, true);
if (ret > 0) { if (ret > 0) {
client_printf(client, "updating_db: %i\n", ret); client_printf(client, "updating_db: %i\n", ret);