command: "update" checks if the path is malformed
This is a very basic check, which only ensures that the path does not begin with a slash, doesn't have double slashes and the special names "." and ".." are forbidden.
This commit is contained in:
@@ -1055,9 +1055,16 @@ handle_update(struct client *client, G_GNUC_UNUSED int argc, char *argv[])
|
||||
unsigned ret;
|
||||
|
||||
assert(argc <= 2);
|
||||
if (argc == 2)
|
||||
if (argc == 2) {
|
||||
path = argv[1];
|
||||
|
||||
if (!uri_safe_local(path)) {
|
||||
command_error(client, ACK_ERROR_ARG,
|
||||
"Malformed path");
|
||||
return COMMAND_RETURN_ERROR;
|
||||
}
|
||||
}
|
||||
|
||||
ret = update_enqueue(path, false);
|
||||
if (ret > 0) {
|
||||
client_printf(client, "updating_db: %i\n", ret);
|
||||
@@ -1076,9 +1083,16 @@ handle_rescan(struct client *client, G_GNUC_UNUSED int argc, char *argv[])
|
||||
unsigned ret;
|
||||
|
||||
assert(argc <= 2);
|
||||
if (argc == 2)
|
||||
if (argc == 2) {
|
||||
path = argv[1];
|
||||
|
||||
if (!uri_safe_local(path)) {
|
||||
command_error(client, ACK_ERROR_ARG,
|
||||
"Malformed path");
|
||||
return COMMAND_RETURN_ERROR;
|
||||
}
|
||||
}
|
||||
|
||||
ret = update_enqueue(path, true);
|
||||
if (ret > 0) {
|
||||
client_printf(client, "updating_db: %i\n", ret);
|
||||
|
Reference in New Issue
Block a user