oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

archive/zzip: fix inverted error handler 

Set the Error when zzip_seek()==-1 and not on success.  Fixes a crash
after seeking.
This commit is contained in:
Max Kellermann 2014-11-24 22:08:11 +01:00
parent 143c735f96
commit a254f5a3a8
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@ -1,4 +1,6 @@
ver 0.18.19 (not yet released) ver 0.18.19 (not yet released)
* archive
- zzip: fix crash after seeking
ver 0.18.18 (2014/11/18) ver 0.18.18 (2014/11/18)
* decoder * decoder

9
src/archive/ZzipArchivePlugin.cxx
View File

@ -186,12 +186,13 @@ zzip_input_seek(InputStream *is, InputPlugin::offset_type offset,
{ {
ZzipInputStream *zis = (ZzipInputStream *)is; ZzipInputStream *zis = (ZzipInputStream *)is;
zzip_off_t ofs = zzip_seek(zis->file, offset, whence); zzip_off_t ofs = zzip_seek(zis->file, offset, whence);
if (ofs != -1) { if (ofs < 0) {
error.Set(zzip_domain, "zzip_seek() has failed"); error.Set(zzip_domain, "zzip_seek() has failed");
is->offset = ofs; return false;
return true;
} }
return false;
is->offset = ofs;
return true;
} }
/* exported structures */ /* exported structures */