oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

decoder/vorbis: handle uri==NULL 

This fixes a theoretical crash, which has never occurred in practice.
This commit is contained in:
Max Kellermann 2010-06-30 23:38:49 +02:00
parent c3569814bd
commit a1882f48be
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -4,6 +4,7 @@ ver 0.15.11 (2010/??/??)
* decoders: * decoders:
- mp4ff: support tags "album artist", "albumartist", "band" - mp4ff: support tags "album artist", "albumartist", "band"
- mikmod: fix memory leak - mikmod: fix memory leak
- vorbis: handle uri==NULL
- ffmpeg: free AVFormatContext on error - ffmpeg: free AVFormatContext on error
- ffmpeg: read more metadata - ffmpeg: read more metadata
* playlist: emit IDLE_OPTIONS when resetting single mode * playlist: emit IDLE_OPTIONS when resetting single mode

3
src/decoder/vorbis_plugin.c
View File

@ -233,6 +233,9 @@ oggvorbis_seekable(struct decoder *decoder)
bool seekable; bool seekable;
uri = decoder_get_uri(decoder); uri = decoder_get_uri(decoder);
if (uri == NULL)
return false;
/* disable seeking on remote streams, because libvorbis seeks /* disable seeking on remote streams, because libvorbis seeks
around like crazy, and due to being very expensive, this around like crazy, and due to being very expensive, this
delays song playback my 10 or 20 seconds */ delays song playback my 10 or 20 seconds */