oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

DetachedSong: add method Update()

Browse Source 
Don't create an intermediate Song instance when all we want is a
DetachedSong.
This commit is contained in:
Max Kellermann
2014-01-15 12:05:44 +01:00
parent df80deb070
commit 9fb82f9687
5 changed files with 55 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/command/OtherCommands.cxx
View File

@@ -23,7 +23,7 @@
#include "CommandError.hxx"
#include "UpdateGlue.hxx"
#include "Directory.hxx"
#include "Song.hxx"
#include "DetachedSong.hxx"
#include "SongPrint.hxx"
#include "TagPrint.hxx"
#include "TagStream.hxx"
@@ -140,15 +140,14 @@ handle_lsinfo(Client &client, int argc, char *argv[])
if (!client_allow_file(client, path_fs, error))
return print_error(client, error);
Song *song = Song::LoadFile(path_utf8, nullptr);
if (song == nullptr) {
DetachedSong song(path_utf8);
if (!song.Update()) {
command_error(client, ACK_ERROR_NO_EXIST,
"No such file");
return CommandResult::ERROR;
}
song_print_info(client, *song);
song->Free();
song_print_info(client, song);
return CommandResult::OK;
}