oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

decoder: return void from decode() methods

Browse Source 
The stream_decode() and file_decode() methods returned a boolean,
indicating whether they were able to decode the song.  This is
redundant, since we already know that: if decoder_initialized() has
been called (and dc.state==DECODE), the plugin succeeded.  Change both
methods to return void.
This commit is contained in:
Max Kellermann
2008-11-11 17:13:44 +01:00
parent 05e69ac086
commit 9eed41911f
13 changed files with 56 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/decoder/mod_plugin.c
View File

@@ -160,7 +160,7 @@ static void mod_close(mod_Data * data)
free(data);
}
static bool
static void
mod_decode(struct decoder *decoder, const char *path)
{
mod_Data *data;
@@ -173,7 +173,7 @@ mod_decode(struct decoder *decoder, const char *path)
if (!(data = mod_open(path))) {
ERROR("failed to open mod: %s\n", path);
MikMod_Exit();
return false;
return;
}
audio_format.bits = 16;
@@ -197,8 +197,6 @@ mod_decode(struct decoder *decoder, const char *path)
mod_close(data);
MikMod_Exit();
return true;
}
static struct tag *modTagDup(const char *file)