oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

[clang-tidy] remove static in namespace 

Found with readability-static-definition-in-anonymous-namespace

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-02-02 14:38:02 -08:00
parent 140d8547c7
commit 9cf1385765
No known key found for this signature in database
GPG Key ID: 36D31CFA845F0E3B
3 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/decoder/plugins/HybridDsdDecoderPlugin.cxx
View File

@ -32,7 +32,7 @@ static constexpr Domain hybrid_dsd_domain("hybrid_dsd");
namespace { namespace {
static bool bool
InitHybridDsdDecoder(const ConfigBlock &block) InitHybridDsdDecoder(const ConfigBlock &block)
{ {
/* this plugin is disabled by default because for people /* this plugin is disabled by default because for people

24
src/decoder/plugins/OpusDecoderPlugin.cxx
View File

@ -41,29 +41,29 @@
namespace { namespace {
static constexpr opus_int32 opus_sample_rate = 48000; constexpr opus_int32 opus_sample_rate = 48000;
/** /**
* Allocate an output buffer for 16 bit PCM samples big enough to hold * Allocate an output buffer for 16 bit PCM samples big enough to hold
* a quarter second, larger than 120ms required by libopus. * a quarter second, larger than 120ms required by libopus.
*/ */
static constexpr unsigned opus_output_buffer_frames = opus_sample_rate / 4; constexpr unsigned opus_output_buffer_frames = opus_sample_rate / 4;
gcc_pure gcc_pure
static bool bool
IsOpusHead(const ogg_packet &packet) noexcept IsOpusHead(const ogg_packet &packet) noexcept
{ {
return packet.bytes >= 8 && memcmp(packet.packet, "OpusHead", 8) == 0; return packet.bytes >= 8 && memcmp(packet.packet, "OpusHead", 8) == 0;
} }
gcc_pure gcc_pure
static bool bool
IsOpusTags(const ogg_packet &packet) noexcept IsOpusTags(const ogg_packet &packet) noexcept
{ {
return packet.bytes >= 8 && memcmp(packet.packet, "OpusTags", 8) == 0; return packet.bytes >= 8 && memcmp(packet.packet, "OpusTags", 8) == 0;
} }
static bool bool
mpd_opus_init(gcc_unused const ConfigBlock &block) mpd_opus_init(gcc_unused const ConfigBlock &block)
{ {
LogDebug(opus_domain, opus_get_version_string()); LogDebug(opus_domain, opus_get_version_string());
@ -266,7 +266,7 @@ MPDOpusDecoder::Seek(uint64_t where_frame)
} }
} }
static void void
mpd_opus_stream_decode(DecoderClient &client, mpd_opus_stream_decode(DecoderClient &client,
InputStream &input_stream) InputStream &input_stream)
{ {
@ -300,7 +300,7 @@ mpd_opus_stream_decode(DecoderClient &client,
} }
} }
static bool bool
ReadAndParseOpusHead(OggSyncState &sync, OggStreamState &stream, ReadAndParseOpusHead(OggSyncState &sync, OggStreamState &stream,
unsigned &channels) unsigned &channels)
{ {
@ -312,7 +312,7 @@ ReadAndParseOpusHead(OggSyncState &sync, OggStreamState &stream,
audio_valid_channel_count(channels); audio_valid_channel_count(channels);
} }
static bool bool
ReadAndVisitOpusTags(OggSyncState &sync, OggStreamState &stream, ReadAndVisitOpusTags(OggSyncState &sync, OggStreamState &stream,
TagHandler &handler) TagHandler &handler)
{ {
@ -325,7 +325,7 @@ ReadAndVisitOpusTags(OggSyncState &sync, OggStreamState &stream,
handler); handler);
} }
static void void
VisitOpusDuration(InputStream &is, OggSyncState &sync, OggStreamState &stream, VisitOpusDuration(InputStream &is, OggSyncState &sync, OggStreamState &stream,
TagHandler &handler) TagHandler &handler)
{ {
@ -339,7 +339,7 @@ VisitOpusDuration(InputStream &is, OggSyncState &sync, OggStreamState &stream,
} }
} }
static bool bool
mpd_opus_scan_stream(InputStream &is, TagHandler &handler) noexcept mpd_opus_scan_stream(InputStream &is, TagHandler &handler) noexcept
{ {
InputStreamReader reader(is); InputStreamReader reader(is);
@ -363,14 +363,14 @@ mpd_opus_scan_stream(InputStream &is, TagHandler &handler) noexcept
return true; return true;
} }
static const char *const opus_suffixes[] = { const char *const opus_suffixes[] = {
"opus", "opus",
"ogg", "ogg",
"oga", "oga",
nullptr nullptr
}; };
static const char *const opus_mime_types[] = { const char *const opus_mime_types[] = {
/* the official MIME type (RFC 5334) */ /* the official MIME type (RFC 5334) */
"audio/ogg", "audio/ogg",

2
src/encoder/plugins/OpusEncoderPlugin.cxx
View File

@ -120,7 +120,7 @@ PreparedOpusEncoder::PreparedOpusEncoder(const ConfigBlock &block)
throw std::runtime_error("Invalid signal"); throw std::runtime_error("Invalid signal");
} }
static PreparedEncoder * PreparedEncoder *
opus_encoder_init(const ConfigBlock &block) opus_encoder_init(const ConfigBlock &block)
{ {
return new PreparedOpusEncoder(block); return new PreparedOpusEncoder(block);