oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

tag/Builder: use std::swap() in move operator

Browse Source 
This way, we save the overhead for acquiring the tag_pool_lock.
This commit is contained in:
Max Kellermann 2021-08-05 14:27:30 +02:00
parent 551c941b5a
commit 96875921b7
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/tag/Builder.cxx
View File

@ -78,11 +78,14 @@ TagBuilder::operator=(const TagBuilder &other) noexcept
TagBuilder & TagBuilder &
TagBuilder::operator=(TagBuilder &&other) noexcept TagBuilder::operator=(TagBuilder &&other) noexcept
{ {
using std::swap;
duration = other.duration; duration = other.duration;
has_playlist = other.has_playlist; has_playlist = other.has_playlist;
RemoveAll(); /* swap the two TagItem lists so we don't need to touch the
items = std::move(other.items); tag pool just yet */
swap(items, other.items);
return *this; return *this;
} }