oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

lib/upnp/Discovery: use strncmp() instead of memcmp()

Browse Source 
memcmp() can overflow the buffer.
This commit is contained in:
Max Kellermann 2017-08-18 13:03:39 +02:00
parent 5ac72211cd
commit 95637fd153
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/upnp/Discovery.cxx
View File

@ -39,7 +39,7 @@ static bool
isCDService(const char *st) noexcept isCDService(const char *st) noexcept
{ {
constexpr size_t sz = sizeof(ContentDirectorySType) - 3; constexpr size_t sz = sizeof(ContentDirectorySType) - 3;
return memcmp(ContentDirectorySType, st, sz) == 0; return strncmp(ContentDirectorySType, st, sz) == 0;
} }
// The type of device we're asking for in search // The type of device we're asking for in search
@ -50,7 +50,7 @@ static bool
isMSDevice(const char *st) noexcept isMSDevice(const char *st) noexcept
{ {
constexpr size_t sz = sizeof(MediaServerDType) - 3; constexpr size_t sz = sizeof(MediaServerDType) - 3;
return memcmp(MediaServerDType, st, sz) == 0; return strncmp(MediaServerDType, st, sz) == 0;
} }
static void static void