oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

*: use transparent comparison for std::{map,set} with std::string keys

Browse Source 
This avoids many std::string temporaries for lookups.
This commit is contained in:
Max Kellermann
2023-03-12 09:11:45 +01:00
parent 27d3dcf14c
commit 8b77da545d
23 changed files with 34 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/output/Control.cxx
View File

@@ -103,12 +103,12 @@ AudioOutputControl::GetMixer() const noexcept
return output ? output->mixer : nullptr;
}
std::map<std::string, std::string>
std::map<std::string, std::string, std::less<>>
AudioOutputControl::GetAttributes() const noexcept
{
return output
? output->GetAttributes()
: std::map<std::string, std::string>{};
: std::map<std::string, std::string, std::less<>>{};
}
void

2
src/output/Control.hxx
View File

@@ -371,7 +371,7 @@ public:
void BeginDestroy() noexcept;
std::map<std::string, std::string> GetAttributes() const noexcept;
std::map<std::string, std::string, std::less<>> GetAttributes() const noexcept;
void SetAttribute(std::string &&name, std::string &&value);
/**

2
src/output/Filtered.cxx
View File

@@ -33,7 +33,7 @@ FilteredAudioOutput::SupportsPause() const noexcept
return output->SupportsPause();
}
std::map<std::string, std::string>
std::map<std::string, std::string, std::less<>>
FilteredAudioOutput::GetAttributes() const noexcept
{
return output->GetAttributes();

2
src/output/Filtered.hxx
View File

@@ -155,7 +155,7 @@ public:
[[gnu::pure]]
bool SupportsPause() const noexcept;
std::map<std::string, std::string> GetAttributes() const noexcept;
std::map<std::string, std::string, std::less<>> GetAttributes() const noexcept;
void SetAttribute(std::string &&name, std::string &&value);
/**

2
src/output/Interface.hxx
View File

@@ -49,7 +49,7 @@ public:
*
* This method must be thread-safe.
*/
virtual std::map<std::string, std::string> GetAttributes() const noexcept {
virtual std::map<std::string, std::string, std::less<>> GetAttributes() const noexcept {
return {};
}

4
src/output/plugins/AlsaOutputPlugin.cxx
View File

@@ -257,7 +257,7 @@ public:
}
private:
std::map<std::string, std::string> GetAttributes() const noexcept override;
std::map<std::string, std::string, std::less<>> GetAttributes() const noexcept override;
void SetAttribute(std::string &&name, std::string &&value) override;
void Enable() override;
@@ -444,7 +444,7 @@ AlsaOutput::AlsaOutput(EventLoop &_loop, const ConfigBlock &block)
allowed_formats = Alsa::AllowedFormat::ParseList(allowed_formats_string);
}
std::map<std::string, std::string>
std::map<std::string, std::string, std::less<>>
AlsaOutput::GetAttributes() const noexcept
{
const std::scoped_lock<Mutex> lock(attributes_mutex);