oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

util/IntrusiveList: fix illegal downcast (ubsan) 

Fixes UBSanitizer warning:

 src/util/IntrusiveList.hxx:108:10: runtime error: downcast of address 0xdeadbeef which does not point to an object of type 'Foo'
This commit is contained in:
Max Kellermann 2023-04-25 11:16:36 +02:00 committed by Max Kellermann
parent 8743326924
commit 80104eb6d5
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/util/IntrusiveList.hxx
View File

@ -492,7 +492,7 @@ public:
GetHookMode() < IntrusiveHookMode::AUTO_UNLINK,
"Can't use auto-unlink hooks with constant_time_size");
auto &existing_node = ToNode(*p);
auto &existing_node = *p.cursor;
auto &new_node = ToNode(t);
IntrusiveListNode::Connect(*existing_node.prev,
@ -529,13 +529,13 @@ public:
if (_begin == _end)
return;
auto &next_node = ToNode(*position);
auto &prev_node = ToNode(*std::prev(position));
auto &next_node = *position.cursor;
auto &prev_node = *std::prev(position).cursor;
auto &first_node = ToNode(*_begin);
auto &before_first_node = ToNode(*std::prev(_begin));
auto &last_node = ToNode(*std::prev(_end));
auto &after_last_node = ToNode(*_end);
auto &first_node = *_begin.cursor;
auto &before_first_node = *std::prev(_begin).cursor;
auto &last_node = *std::prev(_end).cursor;
auto &after_last_node = *_end.cursor;
/* remove from the other list */
IntrusiveListNode::Connect(before_first_node, after_last_node);