oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

tag/ApeTag: don't take reference of IterableSplitString() elements

Browse Source 
This doesn't work because IterableSplitString() returns its elements
by value.

Fixes clang warning:

 loop variable 'i' is always a copy because the range of type 'IterableSplitString' (aka 'BasicIterableSplitString<char>') does not return a reference [-Werror,-Wrange-loop-analysis]
This commit is contained in:
Max Kellermann 2020-02-04 16:53:45 +01:00
parent 3fc859c42d
commit 7c62887df7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tag/ApeTag.cxx
View File

@ -54,14 +54,14 @@ tag_ape_import_item(unsigned long flags,
return false; return false;
if (handler.WantPair()) if (handler.WantPair())
for (const auto &i : IterableSplitString(value, '\0')) for (const auto i : IterableSplitString(value, '\0'))
handler.OnPair(key, i); handler.OnPair(key, i);
TagType type = tag_ape_name_parse(key); TagType type = tag_ape_name_parse(key);
if (type == TAG_NUM_OF_ITEM_TYPES) if (type == TAG_NUM_OF_ITEM_TYPES)
return false; return false;
for (const auto &i : IterableSplitString(value, '\0')) for (const auto i : IterableSplitString(value, '\0'))
handler.OnTag(type, i); handler.OnTag(type, i);
return true; return true;