oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

event/Loop: AbandonFD() unlinks the SocketEvent

Browse Source 
Fixes use-after-free bugs causing assertion failures at shutdown,
because all "abandoned" SocketEvents are still in the linked list.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/986
Closes https://github.com/MusicPlayerDaemon/MPD/issues/987
This commit is contained in:
Max Kellermann 2020-10-28 14:59:55 +01:00
parent 65a1c4a016
commit 7c47fe746c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/event/Loop.cxx
View File

@ -110,6 +110,8 @@ EventLoop::AbandonFD(SocketEvent &event) noexcept
#endif #endif
assert(event.IsDefined()); assert(event.IsDefined());
event.unlink();
return poll_backend.Abandon(event.GetSocket().Get()); return poll_backend.Abandon(event.GetSocket().Get());
} }