oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

decoder/mikmod: fix memory leak 

The return value of Player_LoadTitle() is allocated with malloc(), and
must be freed by the caller.
This commit is contained in:
Max Kellermann 2010-06-30 19:37:36 +00:00
parent 5ebe33653c
commit 77e6810c14
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -3,6 +3,7 @@ ver 0.15.11 (2010/??/??)
- ape: support album artist - ape: support album artist
* decoders: * decoders:
- mp4ff: support tags "albumartist", "band" - mp4ff: support tags "albumartist", "band"
- mikmod: fix memory leak
ver 0.15.10 (2010/05/30) ver 0.15.10 (2010/05/30)

6
src/decoder/mikmod_plugin.c
View File

@ -219,10 +219,12 @@ static struct tag *modTagDup(const char *file)
ret->time = 0; ret->time = 0;
path2 = g_strdup(file); path2 = g_strdup(file);
title = g_strdup(Player_LoadTitle(path2)); title = Player_LoadTitle(path2);
g_free(path2); g_free(path2);
if (title) if (title) {
tag_add_item(ret, TAG_ITEM_TITLE, title); tag_add_item(ret, TAG_ITEM_TITLE, title);
free(title);
}
return ret; return ret;
} }