thread/Thread: move code to Run()

This commit is contained in:
Max Kellermann 2017-02-10 22:43:55 +01:00
parent 4bb89b1755
commit 752ff12c37
2 changed files with 24 additions and 14 deletions

View File

@ -76,6 +76,26 @@ Thread::Join()
#endif #endif
} }
inline void
Thread::Run()
{
#ifndef WIN32
#ifndef NDEBUG
/* this works around a race condition that causes an assertion
failure due to IsInside() spuriously returning false right
after the thread has been created, and the calling thread
hasn't initialised "defined" yet */
defined = true;
#endif
#endif
f(ctx);
#ifdef ANDROID
Java::DetachCurrentThread();
#endif
}
#ifdef _WIN32 #ifdef _WIN32
DWORD WINAPI DWORD WINAPI
@ -83,7 +103,7 @@ Thread::ThreadProc(LPVOID ctx)
{ {
Thread &thread = *(Thread *)ctx; Thread &thread = *(Thread *)ctx;
thread.f(thread.ctx); thread.Run();
return 0; return 0;
} }
@ -94,19 +114,7 @@ Thread::ThreadProc(void *ctx)
{ {
Thread &thread = *(Thread *)ctx; Thread &thread = *(Thread *)ctx;
#ifndef NDEBUG thread.Run();
/* this works around a race condition that causes an assertion
failure due to IsInside() spuriously returning false right
after the thread has been created, and the calling thread
hasn't initialised "defined" yet */
thread.defined = true;
#endif
thread.f(thread.ctx);
#ifdef ANDROID
Java::DetachCurrentThread();
#endif
return nullptr; return nullptr;
} }

View File

@ -93,6 +93,8 @@ public:
void Join(); void Join();
private: private:
void Run();
#ifdef _WIN32 #ifdef _WIN32
static DWORD WINAPI ThreadProc(LPVOID ctx); static DWORD WINAPI ThreadProc(LPVOID ctx);
#else #else