decoder/ffmpeg: fix double free bug

From the avformat_open_input() API documentation: "Note that a user-supplied AVFormatContext will be freed on failure." https://bugs.musicpd.org/view.php?id=4607
2016-12-13 08:34:05 +01:00 · 2016-12-13 08:34:05 +01:00 · 7146f825b2
parent f61a5f5200
commit 7146f825b2
2 changed files with 2 additions and 1 deletions
--- a/2
+++ b/2
@ -1,4 +1,6 @@
 ver 0.19.20 (not yet released)
+* decoder
+  - ffmpeg: fix crash bug

 ver 0.19.20 (2016/12/09)
 * protocol
--- a/src/decoder/plugins/FfmpegDecoderPlugin.cxx
+++ b/src/decoder/plugins/FfmpegDecoderPlugin.cxx
@ -71,7 +71,6 @@ FfmpegOpenInput(AVIOContext *pb,

 	int err = avformat_open_input(&context, filename, fmt, nullptr);
 	if (err < 0) {
-		avformat_free_context(context);
 		SetFfmpegError(error, err, "avformat_open_input() failed");
 		return nullptr;
 	}