oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

command: use ConstBuffer<const char *> for argument list

Browse Source
This commit is contained in:
Max Kellermann
2014-12-06 00:08:08 +01:00
parent 5837a63942
commit 6edfc56c9d
25 changed files with 417 additions and 420 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/command/TagCommands.cxx
View File

@@ -25,15 +25,16 @@
#include "protocol/Result.hxx"
#include "tag/Tag.hxx"
#include "Partition.hxx"
#include "util/ConstBuffer.hxx"
CommandResult
handle_addtagid(Client &client, gcc_unused unsigned argc, char *argv[])
handle_addtagid(Client &client, ConstBuffer<const char *> args)
{
unsigned song_id;
if (!check_unsigned(client, &song_id, argv[1]))
if (!check_unsigned(client, &song_id, args.front()))
return CommandResult::ERROR;
const char *const tag_name = argv[2];
const char *const tag_name = args[1];
const TagType tag_type = tag_name_parse_i(tag_name);
if (tag_type == TAG_NUM_OF_ITEM_TYPES) {
command_error(client, ACK_ERROR_ARG,
@@ -41,7 +42,7 @@ handle_addtagid(Client &client, gcc_unused unsigned argc, char *argv[])
return CommandResult::ERROR;
}
const char *const value = argv[3];
const char *const value = args[2];
Error error;
if (!client.partition.playlist.AddSongIdTag(song_id, tag_type, value,
@@ -52,15 +53,15 @@ handle_addtagid(Client &client, gcc_unused unsigned argc, char *argv[])
}
CommandResult
handle_cleartagid(Client &client, unsigned argc, char *argv[])
handle_cleartagid(Client &client, ConstBuffer<const char *> args)
{
unsigned song_id;
if (!check_unsigned(client, &song_id, argv[1]))
if (!check_unsigned(client, &song_id, args.front()))
return CommandResult::ERROR;
TagType tag_type = TAG_NUM_OF_ITEM_TYPES;
if (argc >= 3) {
const char *const tag_name = argv[2];
if (args.size >= 2) {
const char *const tag_name = args[1];
tag_type = tag_name_parse_i(tag_name);
if (tag_type == TAG_NUM_OF_ITEM_TYPES) {
command_error(client, ACK_ERROR_ARG,