oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

db/plugins/simple/Song: pass StorageFileInfo to UpdateFile()

Browse Source 
Eliminates a redundant GetInfo() call.
This commit is contained in:
Max Kellermann
2024-05-07 21:11:21 +02:00
parent 164b5b0cf3
commit 67f01fbdb6
3 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/SongUpdate.cxx
View File

@@ -34,13 +34,14 @@ Song::IsPluginAvailable() const noexcept
}
SongPtr
Song::LoadFile(Storage &storage, std::string_view path_utf8, Directory &parent)
Song::LoadFile(Storage &storage, std::string_view path_utf8,
const StorageFileInfo &info, Directory &parent)
{
assert(!uri_has_scheme(path_utf8));
assert(path_utf8.find('\n') == path_utf8.npos);
auto song = std::make_unique<Song>(path_utf8, parent);
if (!song->UpdateFile(storage))
if (!song->UpdateFile(storage, info))
return nullptr;
return song;
@@ -51,13 +52,11 @@ Song::LoadFile(Storage &storage, std::string_view path_utf8, Directory &parent)
#ifdef ENABLE_DATABASE
bool
Song::UpdateFile(Storage &storage)
Song::UpdateFile(Storage &storage, const StorageFileInfo &info)
{
const auto &relative_uri = GetURI();
assert(info.IsRegular());
const auto info = storage.GetInfo(relative_uri.c_str(), true);
if (!info.IsRegular())
return false;
const auto &relative_uri = GetURI();
TagBuilder tag_builder;
auto new_audio_format = AudioFormat::Undefined();