oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

replay_gain_info: allocate the struct statically

Browse Source 
Don't allocate each replay_gain_info object on the heap.  Those
objects who held a pointer now store a full replay_gain_info object.
This reduces the number of allocations and heap fragmentation.
This commit is contained in:
Max Kellermann
2010-02-14 20:36:31 +01:00
parent c05e6a1275
commit 5e0117b444
10 changed files with 71 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/decoder/flac_metadata.c
View File

@@ -56,13 +56,13 @@ flac_find_float_comment(const FLAC__StreamMetadata *block,
return true;
}
struct replay_gain_info *
flac_parse_replay_gain(const FLAC__StreamMetadata *block)
bool
flac_parse_replay_gain(struct replay_gain_info *rgi,
const FLAC__StreamMetadata *block)
{
struct replay_gain_info *rgi;
bool found = false;
rgi = replay_gain_info_new();
replay_gain_info_init(rgi);
if (flac_find_float_comment(block, "replaygain_album_gain",
&rgi->tuples[REPLAY_GAIN_ALBUM].gain))
@@ -77,12 +77,7 @@ flac_parse_replay_gain(const FLAC__StreamMetadata *block)
&rgi->tuples[REPLAY_GAIN_TRACK].peak))
found = true;
if (!found) {
replay_gain_info_free(rgi);
rgi = NULL;
}
return rgi;
return found;
}
/**