oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

add various nodiscard

Browse Source 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev
2021-11-11 02:27:17 -08:00
parent a8c77a6fba
commit 5deca66fdc
6 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/archive/plugins/Iso9660ArchivePlugin.cxx
View File

@@ -162,7 +162,7 @@ class Iso9660InputStream final : public InputStream {
std::array<uint8_t, ISO_BLOCKSIZE> data; std::array<uint8_t, ISO_BLOCKSIZE> data;
public: public:
ConstBuffer<uint8_t> Read() const noexcept { [[nodiscard]] ConstBuffer<uint8_t> Read() const noexcept {
assert(fill <= data.size()); assert(fill <= data.size());
assert(position <= fill); assert(position <= fill);

2
src/event/ServerSocket.cxx
View File

@@ -91,7 +91,7 @@ public:
} }
#endif #endif
bool IsDefined() const noexcept { [[nodiscard]] bool IsDefined() const noexcept {
return event.IsDefined(); return event.IsDefined();
} }

2
src/event/SignalMonitor.cxx
View File

@@ -62,7 +62,7 @@ public:
#endif #endif
} }
auto &GetEventLoop() const noexcept { [[nodiscard]] auto &GetEventLoop() const noexcept {
return event.GetEventLoop(); return event.GetEventLoop();
} }

4
src/lib/curl/Global.cxx
View File

@@ -61,7 +61,7 @@ public:
CurlSocket(const CurlSocket &) = delete; CurlSocket(const CurlSocket &) = delete;
CurlSocket &operator=(const CurlSocket &) = delete; CurlSocket &operator=(const CurlSocket &) = delete;
auto &GetEventLoop() const noexcept { [[nodiscard]] auto &GetEventLoop() const noexcept {
return socket_event.GetEventLoop(); return socket_event.GetEventLoop();
} }
@@ -73,7 +73,7 @@ public:
void *userp, void *socketp) noexcept; void *userp, void *socketp) noexcept;
private: private:
SocketDescriptor GetSocket() const noexcept { [[nodiscard]] SocketDescriptor GetSocket() const noexcept {
return socket_event.GetSocket(); return socket_event.GetSocket();
} }

4
src/mixer/plugins/AlsaMixerPlugin.cxx
View File

@@ -128,13 +128,13 @@ private:
} }
[[gnu::pure]] [[gnu::pure]]
double GetNormalizedVolume() const noexcept { [[nodiscard]] double GetNormalizedVolume() const noexcept {
return get_normalized_playback_volume(elem, return get_normalized_playback_volume(elem,
SND_MIXER_SCHN_FRONT_LEFT); SND_MIXER_SCHN_FRONT_LEFT);
} }
[[gnu::pure]] [[gnu::pure]]
unsigned GetPercentVolume() const noexcept { [[nodiscard]] unsigned GetPercentVolume() const noexcept {
return NormalizedToPercent(GetNormalizedVolume()); return NormalizedToPercent(GetNormalizedVolume());
} }

2
src/output/plugins/PipeWireOutputPlugin.cxx
View File

@@ -273,7 +273,7 @@ private:
pw_thread_loop_signal(thread_loop, false); pw_thread_loop_signal(thread_loop, false);
} }
std::chrono::steady_clock::duration Delay() const noexcept override; [[nodiscard]] std::chrono::steady_clock::duration Delay() const noexcept override;
size_t Play(const void *chunk, size_t size) override; size_t Play(const void *chunk, size_t size) override;
void Drain() override; void Drain() override;