oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

mikmod: call MikMod_Exit() only in the finish() method

Browse Source 
Hi -
independently of libmikmod's other problems - there seems
to be a problem in mpd's wrapper: MikMod_Exit() is called
after the first file is decoded, which frees some ressources
within the mikmod library. An attempt to play a second file
leads to a crash. The appended patch fixes this for me.
(I don't know what the "dup" entry is good for - someone
who knows should review that too.)
best regards
Matthias

[mk: removed 3 more MikMod_Exit() invocations]
This commit is contained in:
Matthias Drochner
2009-01-28 19:13:44 +01:00
committed by Max Kellermann
parent 02bfb0c4e4
commit 5b85288664
2 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@@ -38,6 +38,7 @@ ver 0.14.2 (2009/??/??)
* decoders: * decoders:
- ffmpeg: added support for the tags comment, genre, year - ffmpeg: added support for the tags comment, genre, year
- wavpack: pass NULL if the .wvc file fails to open - wavpack: pass NULL if the .wvc file fails to open
- mikmod: call MikMod_Exit() only in the finish() method
* audio outputs: * audio outputs:
- jack: allocate ring buffers before connecting - jack: allocate ring buffers before connecting
- jack: clear "shutdown" flag on reconnect - jack: clear "shutdown" flag on reconnect

6
src/decoder/mikmod_plugin.c
View File

@@ -167,7 +167,6 @@ mod_decode(struct decoder *decoder, const char *path)
if (!(data = mod_open(path))) { if (!(data = mod_open(path))) {
g_warning("failed to open mod: %s\n", path); g_warning("failed to open mod: %s\n", path);
MikMod_Exit();
return; return;
} }
@@ -190,8 +189,6 @@ mod_decode(struct decoder *decoder, const char *path)
} }
mod_close(data); mod_close(data);
MikMod_Exit();
} }
static struct tag *modTagDup(const char *file) static struct tag *modTagDup(const char *file)
@@ -207,7 +204,6 @@ static struct tag *modTagDup(const char *file)
if (moduleHandle == NULL) { if (moduleHandle == NULL) {
g_debug("modTagDup: Failed to open file: %s\n", file); g_debug("modTagDup: Failed to open file: %s\n", file);
MikMod_Exit();
return NULL; return NULL;
} }
@@ -223,8 +219,6 @@ static struct tag *modTagDup(const char *file)
if (title) if (title)
tag_add_item(ret, TAG_ITEM_TITLE, title); tag_add_item(ret, TAG_ITEM_TITLE, title);
MikMod_Exit();
return ret; return ret;
} }