oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

config/Global: remove ConfigBlock::SetUsed() call, let caller do that

Browse Source 
This fixes an old bug which caused the "unused" warnings to be
unreliable; only the first block in the list was marked as being
"used", no matter if it was really used, and the rest was never marked
as "used", suppressing all warnings for them.
This commit is contained in:
Max Kellermann
2018-07-17 21:08:41 +02:00
parent ef38330d74
commit 5b192beaa5
9 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/db/Configured.cxx
View File

@@ -38,10 +38,11 @@ CreateConfiguredDatabase(EventLoop &main_event_loop, EventLoop &io_event_loop,
throw FormatRuntimeError("Found both 'database' (line %d) and 'db_file' (line %d) setting",
param->line, path->line);
if (param != nullptr)
if (param != nullptr) {
param->SetUsed();
return DatabaseGlobalInit(main_event_loop, io_event_loop,
listener, *param);
else if (path != nullptr) {
} else if (path != nullptr) {
ConfigBlock block(path->line);
block.AddBlockParam("path", path->value, path->line);
return DatabaseGlobalInit(main_event_loop, io_event_loop,