Several fixes uncovered with -pedantic

playerData.c:
proper error checking

directory.c:
properly check myFgets() for errors
(it returns NULL on error)

inputPlugins/mp3_plugin.c
get rid of commas at the end of enums

interface.c:
we weren't using long long, so strtoll isn't needed
get rid of void-pointer arithmetic

sllist.c:
get rid of void-pointer arithmetic

compress.c:
get rid of C++ comments, some compilers don't accept them

Note that I personally like void pointer arithmetic, but some
ancient compilers don't support them :(

git-svn-id: https://svn.musicpd.org/mpd/trunk@4510 09075e82-0dd4-0310-85a5-a0d7c8717e4f
This commit is contained in:
Eric Wong
2006-08-01 04:18:41 +00:00
parent 9ccf40b242
commit 5aca21a502
6 changed files with 20 additions and 20 deletions

View File

@@ -253,10 +253,10 @@ void CompressDo(void *data, unsigned int length)
127);
clipped = 0;
// target line
//XDrawPoint(display, window, redGC,
// pn, 127 - TARGET/256);
// amplification edge
/* target line */
/* XDrawPoint(display, window, redGC, */
/* pn, 127 - TARGET/256); */
/* amplification edge */
XDrawLine(display, window, dkyellowGC,
pn,
127 - (peaks[pn]*gainCurrent
@@ -311,7 +311,7 @@ void CompressDo(void *data, unsigned int length)
127 - (peak*gainCurrent
>> (GAINSHIFT + 8)));
// gain indicator
/* gain indicator */
XFillRectangle(display, window, whiteGC, 0, 128,
prefs.buckets, 8);
x = (gainTarget - (1 << GAINSHIFT))*prefs.buckets
@@ -326,7 +326,7 @@ void CompressDo(void *data, unsigned int length)
x, 132 - 1,
x, 132 + 1);
// blue peak line
/* blue peak line */
XDrawLine(display, window, blueGC,
0, 127 - (peak >> 8), prefs.buckets,
127 - (peak >> 8));