oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

clang-tidy: mark a bunch of variables constexpr

Browse Source 
Found with cppcoreguidelines-interfaces-global-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2021-01-16 18:35:31 -08:00
parent 906e82f600
commit 594dfe572b
No known key found for this signature in database
GPG Key ID: 36D31CFA845F0E3B
15 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/archive/ArchiveList.cxx
View File

@ -30,7 +30,7 @@
#include <string.h>
const ArchivePlugin *const archive_plugins[] = {
constexpr const ArchivePlugin *archive_plugins[] = {
#ifdef ENABLE_BZ2
&bz2_archive_plugin,
#endif

2
src/db/Registry.cxx
View File

@ -26,7 +26,7 @@
#include <string.h>
const DatabasePlugin *const database_plugins[] = {
constexpr const DatabasePlugin *database_plugins[] = {
&simple_db_plugin,
#ifdef ENABLE_LIBMPDCLIENT
&proxy_db_plugin,

2
src/db/plugins/simple/SimpleDatabasePlugin.cxx
View File

@ -479,7 +479,7 @@ SimpleDatabase::Unmount(const char *uri) noexcept
return true;
}
const DatabasePlugin simple_db_plugin = {
constexpr DatabasePlugin simple_db_plugin = {
"simple",
DatabasePlugin::FLAG_REQUIRE_STORAGE,
SimpleDatabase::Create,

2
src/decoder/DecoderList.cxx
View File

@ -53,7 +53,7 @@
#include <string.h>
const struct DecoderPlugin *const decoder_plugins[] = {
constexpr const struct DecoderPlugin *decoder_plugins[] = {
#ifdef ENABLE_MAD
&mad_decoder_plugin,
#endif

2
src/encoder/EncoderList.cxx
View File

@ -33,7 +33,7 @@
#include <string.h>
const EncoderPlugin *const encoder_plugins[] = {
constexpr const EncoderPlugin *encoder_plugins[] = {
&null_encoder_plugin,
#ifdef ENABLE_VORBISENC
&vorbis_encoder_plugin,

2
src/filter/Registry.cxx
View File

@ -28,7 +28,7 @@
#include <string.h>
static const FilterPlugin *const filter_plugins[] = {
static constexpr const FilterPlugin *filter_plugins[] = {
&null_filter_plugin,
&route_filter_plugin,
&normalize_filter_plugin,

2
src/input/Registry.cxx
View File

@ -52,7 +52,7 @@
#include "plugins/CdioParanoiaInputPlugin.hxx"
#endif
const InputPlugin *const input_plugins[] = {
constexpr const InputPlugin *input_plugins[] = {
#ifdef ENABLE_ALSA
&input_plugin_alsa,
#endif

2
src/neighbor/Registry.cxx
View File

@ -26,7 +26,7 @@
#include <string.h>
const NeighborPlugin *const neighbor_plugins[] = {
constexpr const NeighborPlugin *neighbor_plugins[] = {
#ifdef ENABLE_SMBCLIENT
&smbclient_neighbor_plugin,
#endif

2
src/output/Registry.cxx
View File

@ -46,7 +46,7 @@
#endif
#include "util/StringAPI.hxx"
const AudioOutputPlugin *const audio_output_plugins[] = {
constexpr const AudioOutputPlugin *audio_output_plugins[] = {
#ifdef HAVE_SHOUT
&shout_output_plugin,
#endif

2
src/output/plugins/AlsaOutputPlugin.cxx
View File

@ -1181,7 +1181,7 @@ try {
LockCaughtError();
}
const struct AudioOutputPlugin alsa_output_plugin = {
constexpr struct AudioOutputPlugin alsa_output_plugin = {
"alsa",
alsa_test_default_device,
&AlsaOutput::Create,

2
src/output/plugins/PulseOutputPlugin.cxx
View File

@ -913,7 +913,7 @@ pulse_output_test_default_device()
return PulseOutput::TestDefaultDevice();
}
const struct AudioOutputPlugin pulse_output_plugin = {
constexpr struct AudioOutputPlugin pulse_output_plugin = {
"pulse",
pulse_output_test_default_device,
PulseOutput::Create,

2
src/playlist/PlaylistRegistry.cxx
View File

@ -43,7 +43,7 @@
#include <cassert>
#include <iterator>
const PlaylistPlugin *const playlist_plugins[] = {
constexpr const PlaylistPlugin *playlist_plugins[] = {
&extm3u_playlist_plugin,
&m3u_playlist_plugin,
&pls_playlist_plugin,

2
src/playlist/plugins/ExtM3uPlaylistPlugin.cxx
View File

@ -147,7 +147,7 @@ static const char *const extm3u_mime_types[] = {
nullptr
};
const PlaylistPlugin extm3u_playlist_plugin =
constexpr PlaylistPlugin extm3u_playlist_plugin =
PlaylistPlugin("extm3u", extm3u_open_stream)
.WithSuffixes(extm3u_suffixes)
.WithMimeTypes(extm3u_mime_types);

2
src/storage/Registry.cxx
View File

@ -29,7 +29,7 @@
#include <string.h>
const StoragePlugin *const storage_plugins[] = {
constexpr const StoragePlugin *storage_plugins[] = {
&local_storage_plugin,
#ifdef ENABLE_SMBCLIENT
&smbclient_storage_plugin,

2
src/storage/plugins/LocalStorage.cxx
View File

@ -170,7 +170,7 @@ CreateLocalStorage(Path base_fs)
return std::make_unique<LocalStorage>(base_fs);
}
const StoragePlugin local_storage_plugin = {
constexpr StoragePlugin local_storage_plugin = {
"local",
nullptr,
};