oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

output/httpd: fix nullptr dereference crash bug

Browse Source 
When `metadata_sent` is `false`, the plugin assumes there is metadata
which must be sent, even if no metadata page was passed to the plugin.
Initializing it to `true` avoids dereferencing this `nullptr`.

Fixes #412
This commit is contained in:
Max Kellermann 2018-11-08 09:37:18 +01:00
parent 7b5ba15170
commit 583208db7e
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@ -3,7 +3,7 @@ ver 0.21.2 (not yet released)
- ffmpeg: require FFmpeg 3.1 or later - ffmpeg: require FFmpeg 3.1 or later
- ffmpeg: fix broken sound with certain codecs - ffmpeg: fix broken sound with certain codecs
* output * output
- httpd: fix crash with "always_on" - httpd: fix two crash bugs
* fix zlib support * fix zlib support
ver 0.21.1 (2018/11/04) ver 0.21.1 (2018/11/04)

5
src/output/plugins/httpd/HttpdClient.hxx
View File

@ -98,8 +98,11 @@ class HttpdClient final
/** /**
* If the current metadata was already sent to the client. * If the current metadata was already sent to the client.
*
* Initialized to `true` because there is no metadata #Page
* pending to be sent.
*/ */
bool metadata_sent = false; bool metadata_sent = true;
/** /**
* The amount of streaming data between each metadata block * The amount of streaming data between each metadata block