oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

tag/Handler: pass StringView to OnTag() and OnPair()

Browse Source 
Eliminates a number of allocations, because callers don't need to copy
the strings to a newly allocated buffer only to null-terminate them.
And most callers don't need to have a null-terminated string.
This commit is contained in:
Max Kellermann
2019-06-06 12:02:55 +02:00
parent 76eb550011
commit 548aa00111
19 changed files with 108 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/read_tags.cxx
View File

@@ -30,6 +30,7 @@
#include "AudioFormat.hxx"
#include "util/ScopeExit.hxx"
#include "util/StringBuffer.hxx"
#include "util/StringView.hxx"
#include "util/PrintException.hxx"
#include <stdexcept>
@@ -58,13 +59,16 @@ public:
printf("duration=%f\n", duration.ToDoubleS());
}
void OnTag(TagType type, const char *value) noexcept override {
printf("[%s]=%s\n", tag_item_names[type], value);
void OnTag(TagType type, StringView value) noexcept override {
printf("[%s]=%.*s\n", tag_item_names[type],
int(value.size), value.data);
empty = false;
}
void OnPair(const char *key, const char *value) noexcept override {
printf("\"%s\"=%s\n", key, value);
void OnPair(StringView key, StringView value) noexcept override {
printf("\"%.*s\"=%.*s\n",
int(key.size), key.data,
int(value.size), value.data);
}
void OnAudioFormat(AudioFormat af) noexcept override {