oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

notify: more cleanups, add error checking for pipe errors 

Don't bother initializing the junk buffer, we really don't care.
The array was also unnecessary and ugly.

Also, avoid returning the byte count we read/wrote since it
unnecessarily exposes internal details of the implementation to
the callers.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7219 09075e82-0dd4-0310-85a5-a0d7c8717e4f
This commit is contained in:
Eric Wong 2008-03-26 10:39:13 +00:00
parent 19d4f6df18
commit 53be85e1b1
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/notify.c
View File

@ -30,18 +30,19 @@ void initNotify(Notify *notify)
strerror(errno));
}
int waitNotify(Notify *notify)
void waitNotify(Notify *notify)
{
char buffer[64];
ssize_t nbytes;
nbytes = read(notify->fds[0], buffer, sizeof(buffer));
return (int)nbytes;
if (read(notify->fds[0], buffer, sizeof(buffer)) < 0)
FATAL("error reading from pipe: %s\n", strerror(errno));
}
int signalNotify(Notify *notify)
void signalNotify(Notify *notify)
{
char buffer[1] = { 0 };
char buffer;
return (int)write(notify->fds[1], &buffer, sizeof(buffer));
if (write(notify->fds[1], &buffer, sizeof(buffer)) < 0 &&
errno != EAGAIN && errno != EINTR)
FATAL("error writing to pipe: %s\n", strerror(errno));
}

4
src/notify.h
View File

@ -40,8 +40,8 @@ typedef struct _Notify {
void initNotify(Notify *notify);
int waitNotify(Notify *notify);
void waitNotify(Notify *notify);
int signalNotify(Notify *notify);
void signalNotify(Notify *notify);
#endif