oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

db/simple/ExportedSong: check src.OwnsTag(), not this->OwnsTag()

Browse Source 
this->OwnsTag() accesses fields that are not yet initialized.
This commit is contained in:
Max Kellermann 2021-07-30 13:08:34 +02:00
parent 64fa76c568
commit 5355335f19
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@ -1,6 +1,8 @@
ver 0.22.10 (not yet released) ver 0.22.10 (not yet released)
* protocol * protocol
- support "albumart" for virtual tracks in CUE sheets - support "albumart" for virtual tracks in CUE sheets
* database
- simple: fix crash bug
ver 0.22.9 (2021/06/23) ver 0.22.9 (2021/06/23)
* database * database

2
src/db/plugins/simple/ExportedSong.hxx
View File

@ -53,7 +53,7 @@ public:
moved-from instance also owned the Tag moved-from instance also owned the Tag
which its LightSong::tag field refers which its LightSong::tag field refers
to */ to */
OwnsTag() ? tag_buffer : src.tag), src.OwnsTag() ? tag_buffer : src.tag),
tag_buffer(std::move(src.tag_buffer)) {} tag_buffer(std::move(src.tag_buffer)) {}
ExportedSong &operator=(ExportedSong &&) = delete; ExportedSong &operator=(ExportedSong &&) = delete;