client/Response: add constant MAX_BINARY_SIZE

Use the same chunk size for all binary commands.

src/client/Response.cxx

@@ -59,6 +59,8 @@ Response::Format(const char *fmt, ...) noexcept
 bool
 Response::WriteBinary(ConstBuffer<void> payload) noexcept
 {
+	assert(payload.size <= MAX_BINARY_SIZE);
+
 	return Format("binary: %zu\n", payload.size) &&
 		Write(payload.data, payload.size) &&
 		Write("\n");

src/client/Response.hxx

@@ -77,6 +77,8 @@ public:
 	bool FormatV(const char *fmt, va_list args) noexcept;
 	bool Format(const char *fmt, ...) noexcept;
 
+	static constexpr size_t MAX_BINARY_SIZE = 8192;
+
 	/**
 	 * Write a binary chunk; this writes the "binary" line, the
 	 * given chunk and the trailing newline.

src/command/FileCommands.cxx

@@ -286,14 +286,13 @@ read_stream_art(Response &r, const char *uri, size_t offset)
 
 	const offset_type art_file_size = is->GetSize();
 
-	constexpr size_t CHUNK_SIZE = 8192;
-	uint8_t buffer[CHUNK_SIZE];
+	uint8_t buffer[Response::MAX_BINARY_SIZE];
 	size_t read_size;
 
 	{
 		std::unique_lock<Mutex> lock(mutex);
 		is->Seek(lock, offset);
-		read_size = is->Read(lock, &buffer, CHUNK_SIZE);
+		read_size = is->Read(lock, &buffer, sizeof(buffer));
 	}
 
 	r.Format("size: %" PRIoffset "\n", art_file_size);