oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

filter/ReplayGain: emit "mixer" event when replay gain changes volume

Browse Source 
Closes https://github.com/MusicPlayerDaemon/MPD/issues/1294
This commit is contained in:
Max Kellermann 2021-10-19 09:51:07 +02:00
parent aa9933c0b5
commit 4f1e79b6b8
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -3,6 +3,7 @@ ver 0.23.1 (not yet released)
- use decimal notation instead of scientific notation - use decimal notation instead of scientific notation
- "load" supports relative positions - "load" supports relative positions
* output * output
- emit "mixer" idle event when replay gain changes volume
- pipewire: emit "mixer" idle events on external volume change - pipewire: emit "mixer" idle events on external volume change
- pipewire: attempt to change the graph sample rate - pipewire: attempt to change the graph sample rate
- snapcast: fix time stamp bug which caused "Failed to get chunk" - snapcast: fix time stamp bug which caused "Failed to get chunk"

5
src/filter/plugins/ReplayGainFilterPlugin.cxx
View File

@ -27,6 +27,7 @@
#include "pcm/Volume.hxx" #include "pcm/Volume.hxx"
#include "util/ConstBuffer.hxx" #include "util/ConstBuffer.hxx"
#include "util/Domain.hxx" #include "util/Domain.hxx"
#include "Idle.hxx"
#include "Log.hxx" #include "Log.hxx"
#include <cassert> #include <cassert>
@ -169,6 +170,10 @@ ReplayGainFilter::Update()
try { try {
mixer_set_volume(mixer, _volume); mixer_set_volume(mixer, _volume);
/* TODO: emit this idle event only for the
current partition */
idle_add(IDLE_MIXER);
} catch (...) { } catch (...) {
LogError(std::current_exception(), LogError(std::current_exception(),
"Failed to update hardware mixer"); "Failed to update hardware mixer");