util/StringCompare: use StringView to simplify inline implementations

src/util/StringCompare.cxx

@@ -28,17 +28,6 @@
  */
 
 #include "StringCompare.hxx"
-#include "StringAPI.hxx"
-
-#include <assert.h>
-#include <string.h>
-
-bool
-StringStartsWith(const char *haystack, const char *needle)
-{
-	const size_t length = StringLength(needle);
-	return StringIsEqual(haystack, needle, length);
-}
 
 bool
 StringEndsWith(const char *haystack, const char *needle)
@@ -51,21 +40,6 @@ StringEndsWith(const char *haystack, const char *needle)
 		       needle, needle_length) == 0;
 }
 
-const char *
-StringAfterPrefix(const char *string, const char *prefix)
-{
-#if !CLANG_CHECK_VERSION(3,6)
-	/* disabled on clang due to -Wtautological-pointer-compare */
-	assert(string != nullptr);
-	assert(prefix != nullptr);
-#endif
-
-	size_t prefix_length = strlen(prefix);
-	return StringIsEqual(string, prefix, prefix_length)
-		? string + prefix_length
-		: nullptr;
-}
-
 const char *
 FindStringSuffix(const char *p, const char *suffix)
 {