oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

tag/VorbisComment: use std::string_view

Browse Source
This commit is contained in:
Max Kellermann
2022-06-30 10:53:54 +02:00
parent 455a412aaa
commit 4765726bda
5 changed files with 19 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/xiph/ScanVorbisComment.cxx
View File

@@ -29,12 +29,12 @@
* the comment value into the tag.
*/
static bool
vorbis_copy_comment(StringView comment,
StringView name, TagType tag_type,
vorbis_copy_comment(std::string_view comment,
std::string_view name, TagType tag_type,
TagHandler &handler) noexcept
{
const auto value = GetVorbisCommentValue(comment, name);
if (!value.IsNull()) {
if (value.data() != nullptr) {
handler.OnTag(tag_type, value);
return true;
}

4
src/lib/xiph/VorbisComments.cxx
View File

@@ -68,8 +68,8 @@ vorbis_scan_comment(StringView comment, TagHandler &handler) noexcept
{
const auto picture_b64 = handler.WantPicture()
? GetVorbisCommentValue(comment, "METADATA_BLOCK_PICTURE")
: nullptr;
if (!picture_b64.IsNull())
: std::string_view{};
if (picture_b64.data() != nullptr)
return ScanVorbisPicture(picture_b64, handler);
ScanVorbisComment(comment, handler);