oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

don't free client resources except in client_close()

Browse Source 
All of the client's resources are freed in client_close().  It is
enough to set the "expired" flag, no need to duplicate lots of
destruction code again and again.
This commit is contained in:
Max Kellermann 2008-08-28 20:03:49 +02:00
parent 61443c13e6
commit 4448b17e2e
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/client.c
View File

@ -670,14 +670,6 @@ static void client_write_deferred(struct client *client)
/* cause client to close */ /* cause client to close */
DEBUG("client %i: problems flushing buffer\n", DEBUG("client %i: problems flushing buffer\n",
client->num); client->num);
buf = client->deferred_send;
do {
struct sllnode *prev = buf;
buf = buf->next;
free(prev);
} while (buf);
client->deferred_send = NULL;
client->deferred_bytes = 0;
client->expired = 1; client->expired = 1;
} }
} }
@ -747,13 +739,6 @@ static void client_write_output(struct client *client)
(unsigned long)client_max_output_buffer_size); (unsigned long)client_max_output_buffer_size);
/* cause client to close */ /* cause client to close */
client->expired = 1; client->expired = 1;
do {
struct sllnode *prev = buf;
buf = buf->next;
free(prev);
} while (buf);
client->deferred_send = NULL;
client->deferred_bytes = 0;
} else { } else {
while (buf->next) while (buf->next)
buf = buf->next; buf = buf->next;