oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

util/IntrusiveHashSet: rename insert() to insert_commit()

Browse Source 
Clarify that the method is not a freestanding insertion method but
should only be used after insert_check().
This commit is contained in:
Max Kellermann 2023-07-21 13:34:13 +02:00 committed by Max Kellermann
parent e133f621a4
commit 42d5b05f54
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/RemoteTagCache.cxx
View File

@ -31,7 +31,7 @@ RemoteTagCache::Lookup(const std::string &uri) noexcept
auto [tag, value] = map.insert_check(uri); auto [tag, value] = map.insert_check(uri);
if (value) { if (value) {
auto item = new Item(*this, uri); auto item = new Item(*this, uri);
map.insert(tag, *item); map.insert_commit(tag, *item);
waiting_list.push_back(*item); waiting_list.push_back(*item);
lock.unlock(); lock.unlock();

2
src/util/IntrusiveHashSet.hxx
View File

@ -235,7 +235,7 @@ public:
* *
* @param bucket the bucket returned by insert_check() * @param bucket the bucket returned by insert_check()
*/ */
constexpr void insert(bucket_iterator bucket, reference item) noexcept { constexpr void insert_commit(bucket_iterator bucket, reference item) noexcept {
++counter; ++counter;
GetBucket(item).insert(bucket, item); GetBucket(item).insert(bucket, item);
} }

6
test/util/TestIntrusiveHashSet.cxx
View File

@ -43,7 +43,7 @@ TEST(IntrusiveHashSet, Basic)
{ {
auto [position, inserted] = set.insert_check(2); auto [position, inserted] = set.insert_check(2);
ASSERT_TRUE(inserted); ASSERT_TRUE(inserted);
set.insert(position, b); set.insert_commit(position, b);
} }
ASSERT_FALSE(set.insert_check(2).second); ASSERT_FALSE(set.insert_check(2).second);
@ -52,7 +52,7 @@ TEST(IntrusiveHashSet, Basic)
{ {
auto [position, inserted] = set.insert_check(a); auto [position, inserted] = set.insert_check(a);
ASSERT_TRUE(inserted); ASSERT_TRUE(inserted);
set.insert(position, a); set.insert_commit(position, a);
} }
set.insert(c); set.insert(c);
@ -100,7 +100,7 @@ TEST(IntrusiveHashSet, Basic)
{ {
auto [position, inserted] = set.insert_check(f); auto [position, inserted] = set.insert_check(f);
ASSERT_TRUE(inserted); ASSERT_TRUE(inserted);
set.insert(position, f); set.insert_commit(position, f);
} }
ASSERT_EQ(set.find(a), set.iterator_to(f)); ASSERT_EQ(set.find(a), set.iterator_to(f));