oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

util/IntrusiveHashSet: rename insert() to insert_commit()

Browse Source 
Clarify that the method is not a freestanding insertion method but
should only be used after insert_check().
This commit is contained in:
Max Kellermann
2023-07-21 13:34:13 +02:00
committed by Max Kellermann
parent e133f621a4
commit 42d5b05f54
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/util/TestIntrusiveHashSet.cxx
View File

@@ -43,7 +43,7 @@ TEST(IntrusiveHashSet, Basic)
{
auto [position, inserted] = set.insert_check(2);
ASSERT_TRUE(inserted);
set.insert(position, b);
set.insert_commit(position, b);
}
ASSERT_FALSE(set.insert_check(2).second);
@@ -52,7 +52,7 @@ TEST(IntrusiveHashSet, Basic)
{
auto [position, inserted] = set.insert_check(a);
ASSERT_TRUE(inserted);
set.insert(position, a);
set.insert_commit(position, a);
}
set.insert(c);
@@ -100,7 +100,7 @@ TEST(IntrusiveHashSet, Basic)
{
auto [position, inserted] = set.insert_check(f);
ASSERT_TRUE(inserted);
set.insert(position, f);
set.insert_commit(position, f);
}
ASSERT_EQ(set.find(a), set.iterator_to(f));