oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

pcm: fixed software volume, broken by unsigned integer

Browse Source 
"volume" was passed as an unsigned integer, which is correct.  It's
just that when it was multiplied with the sample value, the whole
operation was changed to unsigned, breaking the algorithm (and Qball's
ears).  Internally change "volume" to signed.
This commit is contained in:
Max Kellermann 2008-10-09 15:18:09 +02:00
parent ecc3c39e2f
commit 40f59cacda
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/pcm_utils.c
View File

@ -47,8 +47,7 @@ pcm_range(int32_t sample, unsigned bits)
} }
static void static void
pcm_volume_change_8(int8_t *buffer, unsigned num_samples, pcm_volume_change_8(int8_t *buffer, unsigned num_samples, int volume)
unsigned volume)
{ {
while (num_samples > 0) { while (num_samples > 0) {
int32_t sample = *buffer; int32_t sample = *buffer;
@ -61,8 +60,7 @@ pcm_volume_change_8(int8_t *buffer, unsigned num_samples,
} }
static void static void
pcm_volume_change_16(int16_t *buffer, unsigned num_samples, pcm_volume_change_16(int16_t *buffer, unsigned num_samples, int volume)
unsigned volume)
{ {
while (num_samples > 0) { while (num_samples > 0) {
int32_t sample = *buffer; int32_t sample = *buffer;
@ -75,8 +73,7 @@ pcm_volume_change_16(int16_t *buffer, unsigned num_samples,
} }
static void static void
pcm_volume_change_24(int32_t *buffer, unsigned num_samples, pcm_volume_change_24(int32_t *buffer, unsigned num_samples, int volume)
unsigned volume)
{ {
while (num_samples > 0) { while (num_samples > 0) {
int64_t sample = *buffer; int64_t sample = *buffer;