oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

[clang-tidy] convert several loops to const auto&

Browse Source 
Found with performance-for-range-copy

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev
2020-01-31 21:03:57 -08:00
parent bc6eca2115
commit 40d0420648
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/input/InputPlugin.cxx
View File

@@ -33,7 +33,7 @@ InputPlugin::SupportsUri(const char *uri) const noexcept
if (StringStartsWithIgnoreCase(uri, *i)) if (StringStartsWithIgnoreCase(uri, *i))
return true; return true;
} else { } else {
for (auto schema : protocols()) { for (const auto& schema : protocols()) {
if (StringStartsWithIgnoreCase(uri, schema.c_str())){ if (StringStartsWithIgnoreCase(uri, schema.c_str())){
return true; return true;
} }

4
src/ls.cxx
View File

@@ -39,7 +39,7 @@ void print_supported_uri_schemes_to_fp(FILE *fp)
protocols.emplace(uri); protocols.emplace(uri);
}); });
for (auto protocol : protocols) { for (const auto& protocol : protocols) {
fprintf(fp, " %s", protocol.c_str()); fprintf(fp, " %s", protocol.c_str());
} }
fprintf(fp,"\n"); fprintf(fp,"\n");
@@ -54,7 +54,7 @@ print_supported_uri_schemes(Response &r)
protocols.emplace(uri); protocols.emplace(uri);
}); });
for (auto protocol : protocols) { for (const auto& protocol : protocols) {
r.Format("handler: %s\n", protocol.c_str()); r.Format("handler: %s\n", protocol.c_str());
} }
} }

2
src/storage/StorageState.cxx
View File

@@ -139,7 +139,7 @@ storage_state_get_hash(const Instance &instance)
boost::crc_32_type result; boost::crc_32_type result;
for (auto mount: mounts) { for (const auto& mount : mounts) {
result.process_bytes(mount.c_str(), mount.length()); result.process_bytes(mount.c_str(), mount.length());
} }