oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

decoder/DsdLib: check size before seeking

Browse Source
This commit is contained in:
Max Kellermann 2015-01-30 23:19:26 +01:00
parent fd02c87fa2
commit 3ecb19d0f1
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/decoder/plugins/DsdLib.cxx
View File

@ -112,19 +112,18 @@ dsdlib_tag_id3(InputStream &is,
if (tagoffset == 0 || !is.KnownSize()) if (tagoffset == 0 || !is.KnownSize())
return; return;
if (!dsdlib_skip_to(nullptr, is, tagoffset))
return;
/* Prevent broken files causing problems */ /* Prevent broken files causing problems */
const auto size = is.GetSize(); const auto size = is.GetSize();
if (tagoffset >= size) if (tagoffset >= size)
return; return;
const id3_length_t count = size - tagoffset; const id3_length_t count = size - tagoffset;
if (count < 10 || count > 1024 * 1024) if (count < 10 || count > 1024 * 1024)
return; return;
if (!dsdlib_skip_to(nullptr, is, tagoffset))
return;
id3_byte_t *const id3_buf = new id3_byte_t[count]; id3_byte_t *const id3_buf = new id3_byte_t[count];
if (id3_buf == nullptr) if (id3_buf == nullptr)
return; return;