oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

db/Helpers: use reference instead of pointer

This commit is contained in:
Max Kellermann 2014-04-24 10:31:19 +02:00
parent b999e16406
commit 3965b490a9
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/db/Helpers.cxx
View File

@ -26,6 +26,7 @@
#include <functional> #include <functional>
#include <set> #include <set>
#include <assert.h>
#include <string.h> #include <string.h>
struct StringLess { struct StringLess {
@ -40,12 +41,13 @@ typedef std::set<const char *, StringLess> StringSet;
static bool static bool
CollectTags(StringSet &set, TagType tag_type, const LightSong &song) CollectTags(StringSet &set, TagType tag_type, const LightSong &song)
{ {
const Tag *tag = song.tag; assert(song.tag != nullptr);
const Tag &tag = *song.tag;
bool found = false; bool found = false;
for (unsigned i = 0; i < tag->num_items; ++i) { for (unsigned i = 0; i < tag.num_items; ++i) {
if (tag->items[i]->type == tag_type) { if (tag.items[i]->type == tag_type) {
set.insert(tag->items[i]->value); set.insert(tag.items[i]->value);
found = true; found = true;
} }
} }