zero is a valid file descriptor
Although it may not happen in mpd code, it is perfectly possible for a newly allocated file descriptor to be zero. For theoretical correctness, allow 0. git-svn-id: https://svn.musicpd.org/mpd/trunk@7194 09075e82-0dd4-0310-85a5-a0d7c8717e4f
This commit is contained in:

committed by
Eric Wong

parent
c6ceceae8a
commit
33e88ff8f9
@@ -36,8 +36,8 @@ static const char *err_filename;
|
||||
|
||||
static void redirect_logs(void)
|
||||
{
|
||||
assert(out_fd > 0);
|
||||
assert(err_fd > 0);
|
||||
assert(out_fd >= 0);
|
||||
assert(err_fd >= 0);
|
||||
if (dup2(out_fd, STDOUT_FILENO) < 0)
|
||||
FATAL("problems dup2 stdout : %s\n", strerror(errno));
|
||||
if (dup2(err_fd, STDERR_FILENO) < 0)
|
||||
@@ -241,8 +241,8 @@ void close_log_files(void)
|
||||
{
|
||||
if (stdout_mode)
|
||||
return;
|
||||
assert(out_fd > 0);
|
||||
assert(err_fd > 0);
|
||||
assert(out_fd >= 0);
|
||||
assert(err_fd >= 0);
|
||||
xclose(out_fd);
|
||||
xclose(err_fd);
|
||||
}
|
||||
|
Reference in New Issue
Block a user