vorbis_encoder: use vorbis_commentheader_out() in the tag() method

Don't reinitialize the encoder with every tag.
This commit is contained in:
Max Kellermann 2009-03-15 18:36:25 +01:00
parent 2b74311b0a
commit 3333502edb
1 changed files with 15 additions and 6 deletions

View File

@ -302,17 +302,26 @@ copy_tag_to_vorbis_comment(vorbis_comment *vc, const struct tag *tag)
static bool
vorbis_encoder_tag(struct encoder *_encoder, const struct tag *tag,
GError **error)
G_GNUC_UNUSED GError **error)
{
struct vorbis_encoder *encoder = (struct vorbis_encoder *)_encoder;
vorbis_comment comment;
ogg_packet packet;
vorbis_encoder_clear(encoder);
if (!vorbis_encoder_reinit(encoder, error))
return false;
/* write the vorbis_comment object */
copy_tag_to_vorbis_comment(&encoder->vc, tag);
vorbis_comment_init(&comment);
copy_tag_to_vorbis_comment(&comment, tag);
vorbis_encoder_send_header(encoder);
/* convert that vorbis_comment into a ogg_packet */
vorbis_commentheader_out(&comment, &packet);
vorbis_comment_clear(&comment);
/* .. and send it into the ogg_stream_state */
ogg_stream_packetin(&encoder->os, &packet);
ogg_packet_clear(&packet);
return true;
}