archive/Plugin: return std::unique_ptr<ArchiveFile>

2017-12-27 09:07:21 +01:00
parent 5a728a069e
commit 2e0949d8e6
8 changed files with 16 additions and 20 deletions
--- a/src/db/update/Archive.cxx
+++ b/src/db/update/Archive.cxx
@@ -150,7 +150,7 @@ UpdateWalk::UpdateArchiveFile(Directory &parent, const char *name,
 		return;

 	/* open archive */
-	ArchiveFile *file;
+	std::unique_ptr<ArchiveFile> file;
 	try {
 		file = archive_file_open(&plugin, path_fs);
 	} catch (...) {
@@ -177,7 +177,6 @@ UpdateWalk::UpdateArchiveFile(Directory &parent, const char *name,

 	UpdateArchiveVisitor visitor(*this, *file, directory);
 	file->Visit(visitor);
-	delete file;
 }

 bool